AccountModule: Bypass connection hooks on local / unknown networks #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
commented
Jul 6, 2020
| } | ||
|
|
||
| if ( | ||
| clientListening && |
There was a problem hiding this comment.
We still need to check the native client connection; if not we could have a false positive when the client websockets suddenly close.
| const isWalletAndClientSynced = | ||
| Math.abs(walletSyncDelay - clientSyncDelay) <= OK_PROVIDER_SYNC_DELAY | ||
| const networkSlowdown = | ||
| walletSyncDelay >= MILD_PROVIDER_SYNC_DELAY && | ||
| clientSyncDelay >= MILD_PROVIDER_SYNC_DELAY && | ||
| isWalletAndClientSynced | ||
| const networkName = network.shortName.toLowerCase() |
There was a problem hiding this comment.
Using network.shortName instead of network.type due to this issue. The reason I'm not using chainId is because this is only for local / unknown chains where we don't know its behavior, and the chainId can be changed with an environment variable for local networks. Might add a comment for clearing this up!
sohkai
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On local networks that are not simulating block mining, the Account Module eventually will show there may be sync issues / no connection due to it not detecting any activity on-chain. This is desired behavior, but we need to avoid it on local chains.